appearance - show keyboard hints #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #67 +/- ##
==========================================
+ Coverage 92.89% 93.92% +1.02%
==========================================
Files 185 187 +2
Lines 4830 4870 +40
Branches 388 396 +8
==========================================
+ Hits 4487 4574 +87
+ Misses 288 238 -50
- Partials 55 58 +3 ☔ View full report in Codecov by Sentry. |
Currently translated at 97.2% (141 of 145 strings) Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (145 of 145 strings) Translated using Weblate (Dutch) Currently translated at 66.8% (97 of 145 strings) Translated using Weblate (Turkish) Currently translated at 100.0% (145 of 145 strings) Translated using Weblate (Dutch) Currently translated at 64.1% (93 of 145 strings) Translated using Weblate (Swedish) Currently translated at 100.0% (145 of 145 strings) Translated using Weblate (Norwegian Bokmål) Currently translated at 100.0% (145 of 145 strings) Translated using Weblate (Portuguese) Currently translated at 100.0% (145 of 145 strings) Translated using Weblate (Italian) Currently translated at 98.6% (143 of 145 strings) Translated using Weblate (Indonesian) Currently translated at 100.0% (145 of 145 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (145 of 145 strings) Translated using Weblate (Croatian) Currently translated at 100.0% (145 of 145 strings) Co-authored-by: AdVerda <[email protected]> Co-authored-by: Chris <[email protected]> Co-authored-by: Ettore Atalan <[email protected]> Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: Joe Jiang <[email protected]> Co-authored-by: Michele <[email protected]> Co-authored-by: Milo Ivir <[email protected]> Co-authored-by: Petter Reinholdtsen <[email protected]> Co-authored-by: Reza Almanda <[email protected]> Co-authored-by: SC <[email protected]> Co-authored-by: Sabri Ünal <[email protected]> Co-authored-by: bittin1ddc447d824349b2 <[email protected]> Co-authored-by: gallegonovato <[email protected]> Translate-URL: https://hosted.weblate.org/projects/camelot/CamelotApp/de/ Translate-URL: https://hosted.weblate.org/projects/camelot/CamelotApp/es/ Translate-URL: https://hosted.weblate.org/projects/camelot/CamelotApp/hr/ Translate-URL: https://hosted.weblate.org/projects/camelot/CamelotApp/id/ Translate-URL: https://hosted.weblate.org/projects/camelot/CamelotApp/it/ Translate-URL: https://hosted.weblate.org/projects/camelot/CamelotApp/nb_NO/ Translate-URL: https://hosted.weblate.org/projects/camelot/CamelotApp/nl/ Translate-URL: https://hosted.weblate.org/projects/camelot/CamelotApp/pt/ Translate-URL: https://hosted.weblate.org/projects/camelot/CamelotApp/sv/ Translate-URL: https://hosted.weblate.org/projects/camelot/CamelotApp/tr/ Translate-URL: https://hosted.weblate.org/projects/camelot/CamelotApp/zh_Hans/ Translation: Camelot/CamelotApp
…s (hot keys) also in top bar
IngvarX
force-pushed
the
workflow2/feature/appearance-show-keyboard-hints-wip2
branch
from
d02b53c to
24094b4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Improve usability by showing user keyboard shortcuts on screen
Scope
Added new tab called "Appearance" under settings.
(Name and icon were selected to be same as in Google chrome).
The new tab has a checkbox to control whether keyboard hints should be visible in top bar.
For backwards compatibility, the checkbox controls visibility of hints only on top bar, not on bottom (eg F4, F5, etc)
See attached image.
(Future feature in settings is to move also "Theme" from "General" to "Appearance", same as in Google Chrome)