-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
appearance - show keyboard hints #67
appearance - show keyboard hints #67
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #67 +/- ##
==========================================
+ Coverage 92.89% 93.92% +1.02%
==========================================
Files 185 187 +2
Lines 4830 4870 +40
Branches 388 396 +8
==========================================
+ Hits 4487 4574 +87
+ Misses 288 238 -50
- Partials 55 58 +3 ☔ View full report in Codecov by Sentry. |
Currently translated at 97.2% (141 of 145 strings) Translated using Weblate (Chinese (Simplified)) Currently translated at 100.0% (145 of 145 strings) Translated using Weblate (Dutch) Currently translated at 66.8% (97 of 145 strings) Translated using Weblate (Turkish) Currently translated at 100.0% (145 of 145 strings) Translated using Weblate (Dutch) Currently translated at 64.1% (93 of 145 strings) Translated using Weblate (Swedish) Currently translated at 100.0% (145 of 145 strings) Translated using Weblate (Norwegian Bokmål) Currently translated at 100.0% (145 of 145 strings) Translated using Weblate (Portuguese) Currently translated at 100.0% (145 of 145 strings) Translated using Weblate (Italian) Currently translated at 98.6% (143 of 145 strings) Translated using Weblate (Indonesian) Currently translated at 100.0% (145 of 145 strings) Translated using Weblate (Spanish) Currently translated at 100.0% (145 of 145 strings) Translated using Weblate (Croatian) Currently translated at 100.0% (145 of 145 strings) Co-authored-by: AdVerda <[email protected]> Co-authored-by: Chris <[email protected]> Co-authored-by: Ettore Atalan <[email protected]> Co-authored-by: Hosted Weblate <[email protected]> Co-authored-by: Joe Jiang <[email protected]> Co-authored-by: Michele <[email protected]> Co-authored-by: Milo Ivir <[email protected]> Co-authored-by: Petter Reinholdtsen <[email protected]> Co-authored-by: Reza Almanda <[email protected]> Co-authored-by: SC <[email protected]> Co-authored-by: Sabri Ünal <[email protected]> Co-authored-by: bittin1ddc447d824349b2 <[email protected]> Co-authored-by: gallegonovato <[email protected]> Translate-URL: https://hosted.weblate.org/projects/camelot/CamelotApp/de/ Translate-URL: https://hosted.weblate.org/projects/camelot/CamelotApp/es/ Translate-URL: https://hosted.weblate.org/projects/camelot/CamelotApp/hr/ Translate-URL: https://hosted.weblate.org/projects/camelot/CamelotApp/id/ Translate-URL: https://hosted.weblate.org/projects/camelot/CamelotApp/it/ Translate-URL: https://hosted.weblate.org/projects/camelot/CamelotApp/nb_NO/ Translate-URL: https://hosted.weblate.org/projects/camelot/CamelotApp/nl/ Translate-URL: https://hosted.weblate.org/projects/camelot/CamelotApp/pt/ Translate-URL: https://hosted.weblate.org/projects/camelot/CamelotApp/sv/ Translate-URL: https://hosted.weblate.org/projects/camelot/CamelotApp/tr/ Translate-URL: https://hosted.weblate.org/projects/camelot/CamelotApp/zh_Hans/ Translation: Camelot/CamelotApp
…s (hot keys) also in top bar
d02b53c
to
24094b4
Compare
Motivation
Improve usability by showing user keyboard shortcuts on screen
Scope
Added new tab called "Appearance" under settings.
(Name and icon were selected to be same as in Google chrome).
The new tab has a checkbox to control whether keyboard hints should be visible in top bar.
For backwards compatibility, the checkbox controls visibility of hints only on top bar, not on bottom (eg F4, F5, etc)
See attached image.
(Future feature in settings is to move also "Theme" from "General" to "Appearance", same as in Google Chrome)